Conversation
Member
|
The question is, should we possible have just one interface? |
Member
|
It would make the lib code simpler and users code more unified, less confusion. |
Member
|
I did the exact same thing for react-jss some time ago. |
Member
Author
I agree, looks like it's better to make this breaking change now |
Member
Author
|
And I can't get real pros for the previous API |
kof
reviewed
May 9, 2017
| color: (props) => props.theme.textColor | ||
| }) | ||
|
|
||
| // You can also use curried interface this way. |
Member
There was a problem hiding this comment.
but yeah a separate example is still good.
kof
approved these changes
May 9, 2017
Member
|
btw. don't forget to add changelog with breaking change notice and release a new major verison |
kof
approved these changes
May 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: keep just only curried interface